search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
66 stars 67 forks source link

fix: Exchange flipping and style evaluation order to avoid css flicker #1188 #1189

Closed NemethNorbert closed 5 months ago

NemethNorbert commented 5 months ago

Hello,

Issue: 🐛 Bug report

Description LPS-206518

Desired behavior: Applied Style book's style remain unchanged during navigation

Current behavior: Applied Style book's style changes during navigation as it is overridden by theme's style

Other information (environment, versions etc): Reproducible on Liferay 7.3.x and lower

The same fix has been applied to senna within the DXP code base on 7.4 under LPS-202135

bryceosterhaus commented 5 months ago

@NemethNorbert how come this change is being added here? To support older liferay versions, wouldn't we just backport the frontend-js-spa-web module?

NemethNorbert commented 5 months ago

Hey @bryceosterhaus ,

I believe the main reason we have senna in this repo is that we are able to make changes in it and apply it to our older versions. As in 7.3 and older DXP versions senna is not integrated into the frontend-js-spa-web module. It was done for 7.4 under LPS-122511. I think backporting LPS-122511 and all the changes after it would be a larger task than releasing a new version of senna for the older versions of DXP. However this question is probably for the Frontend Infrastructure Dev Team and not me. Right now based on the Repo Description if we want to introduce a change in SPA for 7.3 and lower DXP versions, we should do it trough this repo.

bryceosterhaus commented 5 months ago

@NemethNorbert published under 2.8.0