search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
66 stars 67 forks source link

Liferay Theme Generator fails on Yo version 5.0 #1191

Closed ethib137 closed 5 months ago

ethib137 commented 5 months ago

Issue type (mark with x)

Version (mark with x)

Description

The Liferay Theme Generator errors out when trying to generate a theme with Yo version 5.0.

Desired behavior: The theme generator should work with Yo 5.0.

Current behavior: The theme generator fails with Yo 5.0

Repro instructions (if applicable): If you follow the instructions in the Readme the following error is seen:

Error liferay-theme

instantiatedGenerator.run is not a function

Other information (environment, versions etc): Downgrading to an old version of Yo fixes the issue: npm install -g yo@4.3.1

A similar issue is seen here: https://github.com/yeoman/generator-generator/issues/258

bryceosterhaus commented 5 months ago
Screenshot 2024-01-29 at 11 59 39 AM

This is the compatibility matrix, so I think we just expect that it would only work with v4. We can probably specify that in the readme though

bryceosterhaus commented 5 months ago

Updated READMEs

ethib137 commented 5 months ago

Thanks Bryce! Updating the Readme is a great fix for this. Thanks.