Upgrade node-bourbon

[Machacek76]

Issue type (mark with x)

• [ ] :thinking: Question
• [x ] :bug: Bug report
• [ ] :gift: Feature request
• [ ] :woman_shrugging: Other

Description

Current behavior: could you update the dependency node-bourbon@4.2.3 which is 8 years old? And the build returns an error

[izaera]

Where's that? Type of project? Steps to reproduce? Is it a theme? :thinking:

[Machacek76]

We have a theme on LFR 7.3 and want to upgrade it to LFR 7.4. we proceed according to the instructions and we get this warning during the build.

https://learn.liferay.com/w/dxp/site-building/site-appearance/themes/upgrading-a-theme

Old Package there use this npm package https://www.npmjs.com/package/node-bourbon?activeTab=dependencies

command $ npm run build

package.json

{
    "name": "xxxx-theme",
    "version": "1.0.0",
    "main": "package.json",
    "keywords": [
        "liferay-theme"
    ],
    "liferayTheme": {
        "baseTheme": "styled",
        "fontAwesome": false,
        "screenshot": "",
        "templateLanguage": "ftl",
        "version": "7.4"
    },
    "dependencies": {
        "gulp-include": "2.4.1",
        "gulp-uglify": "3.0.2",
        "@liferay/bs3-bs4-compat": "*"
    },
    "devDependencies": {
        "compass-mixins": "0.12.10",
        "gulp": "4.0.2",
        "gulp-include": "2.4.1",
        "gulp-uglify": "3.0.2",
        "liferay-frontend-theme-styled": "6.0.54",
        "liferay-frontend-theme-unstyled": "6.0.45",
        "liferay-theme-tasks": "^11.5.3",
        "liferay-frontend-css-common": "6.0.8"
    },
    "scripts": {
        "init": "gulp init",
        "build": "gulp build",
        "deploy": "gulp deploy",
        "extend": "gulp extend",
        "kickstart": "gulp kickstart",
        "status": "gulp status",
        "upgrade": "gulp upgrade",
        "watch": "gulp watch"
    }
}

Dependecies list

$ npm list --depth=1 
+-- @liferay/bs3-bs4-compat@1.0.3
+-- compass-mixins@0.12.10
+-- gulp@4.0.2
| +-- glob-watcher@5.0.5
| +-- gulp-cli@2.3.0
| +-- undertaker@1.3.0
| `-- vinyl-fs@3.0.3
+-- gulp-include@2.4.1
| +-- ansi-colors@3.2.4
| +-- event-stream@4.0.1
| +-- glob@7.2.3
| +-- plugin-error@1.0.1
| +-- source-map@0.7.4
| +-- strip-bom@2.0.0
| +-- vinyl@2.2.1
| `-- vinyl-sourcemaps-apply@0.2.1
+-- gulp-uglify@3.0.2
| +-- array-each@1.0.1
| +-- extend-shallow@3.0.2
| +-- gulplog@1.0.0
| +-- has-gulplog@0.1.0
| +-- isobject@3.0.1
| +-- make-error-cause@1.2.2
| +-- safe-buffer@5.2.1
| +-- through2@2.0.5
| +-- uglify-js@3.17.4
| `-- vinyl-sourcemaps-apply@0.2.1 deduped
+-- liferay-frontend-css-common@6.0.8
+-- liferay-frontend-theme-styled@6.0.54
+-- liferay-frontend-theme-unstyled@6.0.45
`-- liferay-theme-tasks@11.5.3
  +-- ansi-colors@4.1.3
  +-- async@2.6.4
  +-- chalk@3.0.0
  +-- compass-mixins@0.12.10 deduped
  +-- cross-spawn@2.2.3
  +-- css-stringify@2.0.0
  +-- event-stream@4.0.1 deduped
  +-- fancy-log@1.3.3
  +-- fs-extra@8.1.0
  +-- globby@4.1.0
  +-- gulp-if@2.0.2
  +-- gulp-inject@5.0.5
  +-- gulp-insert@0.5.0
  +-- gulp-postcss@8.0.0
  +-- gulp-rename@1.4.0
  +-- gulp-replace-task@0.11.0
  +-- gulp-sass@5.1.0
  +-- gulp-sourcemaps@1.6.0
  +-- gulp-terser@2.1.0
  +-- gulp-util@3.0.8
  +-- gulp-watch@5.0.1
  +-- gulp-zip@3.2.0
  +-- http-proxy@1.18.1
  +-- inquirer@0.12.0
  +-- liferay-frontend-common-css@1.0.4
  +-- liferay-npm-build-tools-common@2.32.0
  +-- lodash@4.17.21
  +-- minimist@1.2.8
  +-- node-bourbon@4.2.3
  +-- npm-keyword@5.0.0
  +-- opn@5.5.0
  +-- package-json@5.0.0
  +-- plugin-error@1.0.1 deduped
  +-- portfinder@1.0.32
  +-- resolve@1.22.8
  +-- sass@1.64.1
  +-- tar-fs@1.16.3
  +-- through2@2.0.5 deduped
  +-- tiny-lr@1.1.1
  +-- vinyl-paths@1.0.0
  `-- xml2js@0.4.23

[izaera]

Oh, I see, so it's coming from liferay-theme-tasks not the theme itself...

However, I think it pulls it because it is used in DXP itself, not because the tool does something with it internally, so I cannot give you an answer.

@ethib137 is this something that can be updated or does it depend on DXP's target version? :thinking:

[ethib137]

@pat270 could you answer this? I think you know the context on this one, right?

[Machacek76]

Any progress??

[pat270]

Bourbon is a dependency of "liferay-frontend-css-common": "6.0.8". It contains our deprecated media query mixins from 6.2-7.0? I'm not exactly sure on the exact versions. You can remove that dependency in your package.json.