search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
66 stars 67 forks source link

fix(alloy-ui): AUI-3222 Avoid calling selectionChange on invaild dates #1201

Closed fortunatomaldonado closed 2 months ago

fortunatomaldonado commented 2 months ago

https://liferay.atlassian.net/browse/AUI-3222 https://liferay.atlassian.net/browse/LPD-22812

This is to fix errors in the console when erasing the hour or minutes of input time. By preventing firing selectionChange when the date is invalid, we are able to keep the same behavior without having errors in the log.

If we try to fix this in input_time/page.jsp the time will revert to --:--:- which will be tedious for users having to reenter the time again. Screencast from 04-10-2024 11:12:46 AM.webm

fortunatomaldonado commented 2 months ago

Thank you @markocikos for reviewing this!

Do we know who can merge this?

Thank you for the help!