Add minification to build process

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects

Other

69 stars 69 forks source link

Add minification to build process #237

Closed jbalsas closed 3 years ago

jbalsas commented 3 years ago

As per Design of new JS minification scheme in DXP, the initial goal is to:

Implement build changes to handle the simple case of independent files
Implement changes to handle the more complex case of embedded JS

This should be done in the context of a new Single Build architecture with the following constraints:

Minification happens during build time
Files are minified in place or keep the same name to avoid having to branch off served resources during runtime
Minification is enabled through NODE_ENV variable

wincent commented 3 years ago

groundhog-day

wincent commented 3 years ago

This whole issue smacks of retcon.

jbalsas commented 3 years ago

Did we?

jbalsas commented 3 years ago

Just for reference, I just enabled Exalate in this repo, which tracks Issues and Milestones, so I kinda created this one to test which created https://issues.liferay.com/browse/IFI-2137 which is already assigned to yourself and In Progress in the current episode.

I couldn't directly use https://github.com/liferay/liferay-frontend-projects/pull/233 because we just track issues and not orphaned PRs, but I'm open to add that to the workflow! 😉

wincent commented 3 years ago

noice

jbalsas commented 3 years ago

Toight!!

wincent commented 3 years ago

Closed by: https://github.com/liferay/liferay-frontend-projects/pull/233