search

liferay / liferay-js-themes-toolkit

MIT License
26 stars 28 forks source link

fix: Liferay Theme Tasks update versions for liferay-frontend-theme-s… #514

Closed pat270 closed 3 years ago

pat270 commented 4 years ago

…tyled 5.0.13 and liferay-frontend-theme-unstyled 5.0.17 to match 7.3 GA5

I'm not sure these are actually the right version numbers for 7.3 GA5. The commit message artifact:ignore frontend-theme-styled 5.0.12 prep next confuses me. Is unstyled actually 5.0.16 and styled 5.0.12 for GA5?

'liferay-frontend-theme-styled': strict('5.0.13'),
'liferay-frontend-theme-unstyled': strict('5.0.17'),

I took it from: unstyled https://github.com/liferay/liferay-portal/blob/6d28f4266948e7b0eeb14c3e8d16b3d81e02e8bb/modules/apps/frontend-theme/frontend-theme-unstyled/package.json styled https://github.com/liferay/liferay-portal/blob/6d28f4266948e7b0eeb14c3e8d16b3d81e02e8bb/modules/apps/frontend-theme/frontend-theme-styled/package.json

I also noticed 'liferay-frontend-common-css': strict('1.0.4'). It seems like that package name got changed to liferay-frontend-css-common some time ago? See https://github.com/liferay/liferay-portal/tree/6d28f4266948e7b0eeb14c3e8d16b3d81e02e8bb/modules/apps/frontend-css/frontend-css-common.

wincent commented 4 years ago

I'm not sure these are actually the right version numbers for 7.3 GA5. The commit message artifact:ignore frontend-theme-styled 5.0.12 prep next confuses me. Is unstyled actually 5.0.16 and styled 5.0.12 for GA5?

Sadly, I have no idea... 😱

I think the main thing to do is confirm that those versions actually got published to npm:

yarn init -y
yarn add liferay-frontend-theme-styled@5.0.13 liferay-frontend-theme-unstyled@5.0.17

and snoop to see what versions have been published:

yarn info liferay-frontend-theme-styled versions
yarn info liferay-frontend-theme-unstyled versions

I see later artefacts there (5.0.15 and 5.0.20), respectively... Maybe @izaera or @jbalsas can remember the details here. 🤔

I also noticed 'liferay-frontend-common-css': strict('1.0.4'). It seems like that package name got changed to liferay-frontend-css-common some time ago? See https://github.com/liferay/liferay-portal/tree/6d28f4266948e7b0eeb14c3e8d16b3d81e02e8bb/modules/apps/frontend-css/frontend-css-common.

AFAIK, the OSGi module name (liferay-frontend-css-common) doesn't matter here; the npm package name (liferay-frontend-common-css) is the one that matters.

pat270 commented 4 years ago

@wincent we also have https://www.npmjs.com/package/liferay-frontend-css-common 😕

I think my initial hunch is right, 7.3 GA5 unstyled package.json and liferay-theme-unstyled 5.0.16. liferay-theme-unstyled@5.0.17 uses @clayui/css@3.18.0.

wincent commented 4 years ago

@wincent we also have https://www.npmjs.com/package/liferay-frontend-css-common 😕

I was going to say 🤦‍♂️, but seeing as it was last published 5 years ago, I'm going to go with 😂

jbalsas commented 4 years ago

@wincent we also have https://www.npmjs.com/package/liferay-frontend-css-common 😕

I was going to say 🤦‍♂️, but seeing as it was last published 5 years ago, I'm going to go with 😂

We gonna kill that

izaera commented 4 years ago

Maybe @izaera or @jbalsas can remember the details here. thinking

AFAIK, we don't control what is published and when. It happens the same with themes.

So, we can only be reactive as we've been in #518, where we had to change theme version numbers.

wincent commented 3 years ago

We're going to archive this repo (mark it read-only), as we've migrated the code to the liferay-frontend-projects monorepo now. If this is still relevant, can we resend it there?