fix: #565 don't break source maps

liferay / liferay-js-toolkit

GNU Lesser General Public License v3.0

52 stars 41 forks source link

fix: #565 don't break source maps #612

Closed izaera closed 4 years ago

izaera commented 4 years ago

Don't break source maps for single source transformations.

Note that this doesn't fix the case where one single output file maps to multiple input files.

See https://github.com/liferay/liferay-js-toolkit/issues/565#issuecomment-654883046 for more info.

jbalsas commented 4 years ago

Like the song... "Don't Go Breaking My SourceMaps"...

mfreeman-xtivia commented 4 years ago

So will bundler v3 support source maps? for things like React portlets? and if so how do i switch the build mode from production to development since lnbs-build seems to be in charge of that

izaera commented 4 years ago

@mfreeman-xtivia we want to support source maps, but it's proving much more difficult than we thought at first, second and third :-(. Basically, we need to do something that no one else has done yet, AFAIK, which is translating source maps for multiple file bundles.

wincent commented 4 years ago

Going to close this as we've migrated everything in the toolkit to the liferay-frontend-projects monorepo. We can re-send the PR there if we want to revisit this line of development in the future. This (liferay-js-toolkit) repo will soon be moved into archived (read-only) mode.