search

liferay / liferay-mobile-sdk

Other
47 stars 56 forks source link

Cookie authentication changes #39

Closed victorg1991 closed 7 years ago

victorg1991 commented 7 years ago

Hi guys!

I'm here again with another PR 🎉

This is change is similar to iOS one, we need username and password in the cookieAuthentication class. In this one we have added a sync method to get the cookie auth because it fits better with our current architecture.

Any comments would be appreciated

Thanks! :)

victorg1991 commented 7 years ago

This is the last pull we need to be merged for our next Liferay Screens release :) @brunofarache @sgosantos

Thanks!

sgosantos commented 7 years ago

Just started reviewing :)

:octocat: Sent from GH.

sgosantos commented 7 years ago

I've reviewed the code, but it seems I don't have permission to push the changes. @brunofarache, can you give it to me?

sgosantos commented 7 years ago

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.