liferay / liferay-mobile-sdk

Other
47 stars 56 forks source link

Fix cookie auth in liferay 6.2 #40

Closed victorg1991 closed 7 years ago

victorg1991 commented 7 years ago

Hi! Sorry for the multiple PR's I was having a problem to use cookie login in 6.2 URLSession without a delegate was not setting the cookings correctly in redirects. I had to change the callback based method in urlsession for the delegate one.

I hope you find the changes fine :) Regards!

sgosantos commented 7 years ago

Just started reviewing :)

:octocat: Sent from GH.

sgosantos commented 7 years ago

@victorg1991 signInWithSession is not static anymore, so tests are broken. Also, can't we keep it static? If we change it to be an instance method, apps won't compile after upgrading to the new version.

sgosantos commented 7 years ago

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.