search

liferay / liferay-mobile-sdk

Other
47 stars 56 forks source link

Handle Cookie login refresh in Mobile SDK #52

Closed victorg1991 closed 6 years ago

victorg1991 commented 6 years ago

Here is the PR I told you about last friday, with this changes the mobile-sdk will be the responsible to handle the cookie refresh

If you have any question I'll be happy to answer them :D

victorg1991 commented 6 years ago

Can you review it @jmnavarro ?

jmnavarro commented 6 years ago

hey @allanragec Can you have a look at this PR? Feel free to ask anything you need

allanragec commented 6 years ago

@jmnavarro yes, I'm going to review on Friday

allanragec commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

jmnavarro commented 6 years ago

@allanragec any feedback on your side? we need to merge in these week

allanragec commented 6 years ago

@jmnavarro I did not have time on Friday, because I changed my Mac and I'm still configuring my environment, but I will try on this afternoon.

I'm asking to @victorg1991 to fix the CookieAuthenticationTest

allanragec commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

allanragec commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

allanragec commented 6 years ago

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.