Closed victorg1991 closed 6 years ago
Just started reviewing :)
:octocat: Sent from GH.
Requested to fix tests
The test are working using gradle. Android Studio doesn't like it tho ¯_(ツ)_/¯ If you want to try them in AS, change the build.gradle from liferay-android-sdk-core to:
apply from: '../common.gradle'
dependencies {
api group: 'com.squareup.okhttp', name: 'okhttp', version: '2.7.5'
api 'net.openid:appauth:0.7.0'
}
I hadn't wanted to change this because I don't want to expose those libraries in the artifact
@victorlaerte
Just started reviewing :)
:octocat: Sent from GH.
Hey!
In this PR I've split the mobile sdk into 4 modules, as follows:
With all this you should be able to fine grained select the things that you want to use. There is a small nit, you cannot import more than one set of services, becasue, as the depend on the mobile-sdk you will import two times the core and the compilation will fail. I thought that this won't be problem, its a thing we have to document, but if someone want to do this, they can rely on the 'liferay-android-sdk' artifact that has all the services within it
Any comments?