Save only when necessary

liferay / liferay-module-config-generator

GNU Lesser General Public License v3.0

4 stars 8 forks source link

Save only when necessary #35

Closed shinnlok closed 7 years ago

shinnlok commented 7 years ago

@jbalsas

Issue found Travis CI when trying to build on 1.2.0. The build process was getting failing/getting stuck on:

Successfully started process 'command '/home/travis/build/liferay/../build/node/bin/node''

I noticed that after b1542a8 files were being saved multiple times even if nothing has been changed. After a certain number of writes to the files, travis just stops working and times out.

jbalsas commented 7 years ago

Just started reviewing :)

:octocat: Sent from GH.

jbalsas commented 7 years ago

Hey @shinnlok, thanks for catching this!

We were still saving more than necessary, so I've sent this updated PR: https://github.com/liferay/liferay-module-config-generator/pull/38

In general, our guidelines state that:

We need to report an issue: I created https://github.com/liferay/liferay-module-config-generator/issues/36
All commits need to contain the text Fixes #xx so we can track the
We always try to add tests for bug fixes and features