search

liferay / liferay-npm-tools

Collection of tools for using npm in Liferay
Other
18 stars 15 forks source link

chore(preset): add @clayui/empty-state, @clayui/upper-toolbar to preset #462

Closed wincent closed 4 years ago

wincent commented 4 years ago

These are the last packages missing from the preset:

We did this yesterday for @clayui/layout in 9227c42600a981a30bac8aae6d0a432592d5c929, but I didn't realize that we'd also forgotten these packages (I checked as a result of this Slack thread).

I compared with the current contents of the frontend-taglib-clay package.json file in liferay-portal and determined that there is nothing else missing.

wincent commented 4 years ago

cc @bryceosterhaus, @kresimir-coko: seems like it might be time to add an item to the Clay release checklist reminding us to add any new packages to the preset.

wincent commented 4 years ago

Seeing as this is simple config, going to merge it.

Proviso: I know that we're currently moving stuff into a new @clayui/toolbar package, but it seems harmless to add upper-toolbar to the preset anyway (although it's not being used in liferay-portal at all yet).

wincent commented 4 years ago

Currently trying to forward from: https://github.com/wincent/liferay-portal/pull/315