search

liferay / liferay-npm-tools

Collection of tools for using npm in Liferay
Other
18 stars 15 forks source link

chore: update JS toolkit dependencies from v2.19.1 to v2.19.2 #497

Closed wincent closed 4 years ago

wincent commented 4 years ago

Because we need this revert.

Done with:

cd packages/liferay-npm-bundler-preset-liferay-dev
yarn add \
  babel-preset-liferay-standard@2.19.2 \
  liferay-npm-bundler-loader-css-loader@2.19.2 \
  liferay-npm-bundler-plugin-{exclude-imports,inject-imports-dependencies,inject-peer-dependencies,namespace-packages,replace-browser-modules,resolve-linked-dependencies}@2.19.2
cd ../liferay-npm-scripts
yarn add \
  liferay-npm-bridge-generator@2.19.2 \
  liferay-npm-bundler@2.19.2

Note that we have some cross-project coupling going on here that lead to duplicates in the yarn.lock file (output trimmed for brevity):

$ yarn why liferay-npm-bundler-plugin-resolve-linked-dependencies
[1/4] 🤔  Why do we have the module "liferay-npm-bundler-plugin-resolve-linked-dependencies"...?
=> Found "liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.2"
   - Hoisted from "_project_#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"
   - Hoisted from "_project_#liferay-npm-bundler-preset-liferay-dev#liferay-npm-bundler-plugin-resolve-linked-dependencies"
=> Found "liferay-theme-tasks#liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.1"
   - Hoisted from "_project_#liferay-npm-scripts#liferay-theme-tasks#liferay-npm-build-tools-common#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"

Neither yarn nor a yarn install --force were enough to get rid of it; had to go with rm yarn.lock && yarn. This gets rid of the duplicate dependencies from the liferay-js-toolkit project, but there are a bunch of others in here still, hopefully benign (eg. look at the @storybook dupes in there).

wincent commented 4 years ago

CI is green and this is a routine update, so going to merge.

I don't like the size of the yarn.lock diff, but that won't have downstream effects in the dependency graph of liferay-portal, which is the only thing I care about here.