search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Let the theme config how main sass files are defined #15

Closed yuchi closed 8 years ago

yuchi commented 8 years ago

Related to #14

yuchi commented 8 years ago

Horribly sorry for the dirty commit log, please let me know if you prefer a rebased PR.

robframpton commented 8 years ago

Hey @yuchi

I'd rather not have to publish a new version just for this since it would be a temporary workaround that would be removed in the next release, and everyone using it would be prompted to download the newest version for really no reason. Instead can you just point the lifray-theme-tasks dependency in your theme's package.json to your branch until the permanent changes are in place? I believe this should work...

"liferay-theme-tasks": "yuchi/liferay-theme-tasks#cross-version-compilation"

yuchi commented 8 years ago

That's what I'm currently doing. No worries!