search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

_.trimRight in build task removes letter 'e' when used in a theme name #21

Closed travisrcory closed 8 years ago

travisrcory commented 8 years ago

Hey guys,

When building a theme that has the letter 'e' as the last letter before appending '-theme' the _.trimRight method used here will remove that last 'e'. This causes issues when trying to reference the theme from a sitemap.json. I've opened this pr as a potential fix to ensuring that only the '-theme' is removed from the theme id string. Thanks!

https://github.com/liferay/liferay-theme-tasks/pull/20

travisrcory commented 8 years ago

Fixed by b660a687d559e9666173529dcbd1b78863a31610 thanks @Robert-Frampton !