liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

theme deploy broken since 1.3 #25

Closed kairos666 closed 8 years ago

kairos666 commented 8 years ago

upgarding from v1.2.3 to 1.3 trigger this

when building a new theme for v7 (FTL, no themelets) no changes just deploying it. --> generate error 500 servlet context

kairos666 commented 8 years ago

Those variables are missing in init.ftl (inherited from styled parent theme) --> assigning those seems to help but admin panels still have some issues

<#assign user_id = user.getUserId() /> <#assign is_default_user = user.isDefaultUser() /> <#assign is_setup_complete = user.isSetupComplete() /> <#assign user_first_name = user.getFirstName() /> <#assign user_middle_name = user.getMiddleName() /> <#assign user_last_name = user.getLastName() /> <#assign user_name = user.getFullName() /> <#assign is_male = user.isMale() /> <#assign is_female = user.isFemale() /> <#assign user_birthday = user.getBirthday() /> <#assign user_email_address = user.getEmailAddress() /> <#assign language = locale.getLanguage() /> <#assign language_id = user.getLanguageId() /> <#assign w3c_language_id = localeUtil.toW3cLanguageId(theme_display.getLanguageId()) /> <#assign time_zone = user.getTimeZoneId() /> <#assign user_greeting = htmlUtil.escape(user.getGreeting()) /> <#assign user_comments = user.getComments() /> <#assign user_login_ip = user.getLoginIP() /> <#assign user_last_login_ip = user.getLastLoginIP() />

robframpton commented 8 years ago

Hi @kairos666

It looks like some non-backwards compatible changes were merged into the unstyled base theme which supplies the init.ftl file which has caused your issue.

For a temporary workaround I would recommend adding these variables to your theme's init_custom.ftl file until we can either undo these changes or find another solution.

kairos666 commented 8 years ago

Hi @Robert-Frampton

Thanks for the confirmation. Will do with the workaround for the time being.