search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Support for Source Maps in SCSS compilation #29

Closed yuchi closed 6 years ago

yuchi commented 8 years ago

While we can specify sassOptions.sourceMap to true there’s no actual support, given the need for gulp-sourcemaps (see here).

Would you accept a PR for this?

robframpton commented 8 years ago

I think it's a good idea, as long as we can make it optional and configurable.

yuchi commented 8 years ago

Babel compilation source maps are on by default. If I'd make a pull request what would you expect?

yuchi commented 7 years ago

Do you have any update on this? Are you still waiting for contributions?

jbalsas commented 6 years ago

I think we got this in... closing here, but in the unforgivable case this is still not the case, please, @yuchi, file a grievance complain at the new liferay-themes-sdk location.

Thanks!