liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Theme dependent on another OSGi bundle: how? #34

Closed caneta closed 6 years ago

caneta commented 7 years ago

In Liferay 7, If I had a normal OSGi bundle, I could declare a dependency to another bundle writing the following inside its build.gradle file:

dependencies {
  compile group: "it.mycompany", name: "mycompany.experiment.dev.lib", version: "1.0.0"
}

But how to do the same thing for a Liferay 7 theme? How to make a theme dependent to another OSGi bundle?

I know a theme is an OSGi bundle too, but my problem is that I have no bnd.bnd and build.gradle files...in addition the build system is Gulp and not Gradle (at least not directly): so how to achieve the same goal for a theme?

Thank you

robframpton commented 7 years ago

Hey @caneta,

In portal what we do is wrap themes in a module and have a gradle task take care of installing the npm dependencies and calls gulp for building/deploying. That way it has a bnd.bnd and build.gradle file which should allow you to do what you need.

jbalsas commented 6 years ago

Hey @caneta, I'm closing here for now. We're still generating war files for themes, and we currently don't have full OSGi support for them. This will be initially handled on the Liferay side, but it is not a priority at the moment.

If this is critical for you, would you mind to file a new issue in the new repo location at ~liferay-themes-sdk~ liferay-themes-sdk with your use case so we can analyze it further?

Thanks!

caneta commented 6 years ago

Ok, I will. Little typo: the liferay-themes-sdk link above leads to the old liferay-themes-tasks/issues list: the correct one should be liferay-themes-sdk issue list

jbalsas commented 6 years ago

🙈 thanks @caneta, updated the link in my comment :)