search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Command gulp upgrade -v 6.2 returns gulp version information #42

Closed trevor-ryan-burkholder closed 6 years ago

trevor-ryan-burkholder commented 7 years ago

Command gulp upgrade -v 6.2 returns gulp version information.

trevor-ryan-burkholder commented 7 years ago

var version = argv.a || argv.version; had to be changed to var version = argv.lrv || argv.liferayVersion; at line 25 within upgrade.js which makes gulp upgrade --lrv 6.2 and gulp upgrade --liferayVersion 6.2 work correctly.

jbalsas commented 6 years ago

Hey @TBurk83, sorry for the delayed response... I think we made some changes since this, as I can't get this to behave as you describe.

Would you mind verifying again and if this is still an issue filing a new one at the new repo location at liferay-themes-sdk repo?

Thanks