search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

"Upgrade" Gulp Task: publishConfig:tag never gets updated to 7_0_0 #43

Closed blzaugg closed 7 years ago

blzaugg commented 7 years ago

Expected:

    ...
    "publishConfig": {
        "tag": "7_0_0"
    }
    ...

In below package.json output:

{
    "name": "my-awesome-theme",
    "version": "0.0.0",
    "main": "package.json",
    "keywords": [
        "liferay-theme"
    ],
    "liferayTheme": {
        "baseTheme": "styled",
        "screenshot": "",
        "rubySass": false,
        "templateLanguage": "vm",
        "version": "7.0"
    },
    "devDependencies": {
        "gulp": "^3.8.10",
        "liferay-theme-tasks": "*",
        "liferay-theme-deps-7.0": "*"
    },
    "publishConfig": {
        "tag": "6_2_x"
    }
}
alexandervalencia commented 7 years ago

The publishConfig property is now removed from the package.json generated by generator-liferay-theme. See: https://github.com/liferay/generator-liferay-theme/pull/26

blzaugg commented 7 years ago

https://github.cohttps://github.com/liferay/liferay-theme-tasks/pull/61#issuecomment-329244715m/liferay/liferay-theme-tasks/pull/61#issuecomment-329244715