search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Investigate themelets #60

Closed robframpton closed 6 years ago

robframpton commented 7 years ago

We should investigate if anyone is using this functionality. If we can remove it we should, it will help us remove some old code and simplify the tools.

If we do, we can also remove the themelet generator from generator-liferay-theme.

izaera commented 6 years ago

Hey @Robert-Frampton , why do you think themelets are bad? They look like a quite good idea to reuse fragments of themes... 🤔

Also, the code inside the gulp tasks is not so difficult to maintain, IMO.

/CC @jbalsas @marcoscv-work

robframpton commented 6 years ago

I don't think they are bad. It's just nobody uses them at this point. If nobody found them useful, then we might as well lift the burden of maintaining that functionality.

LucyI commented 6 years ago

I have them on my list of things to learn about, just have not had time. They sound very useful actually! If there is a tutorial somewhere I'd appreciate the link...

mwilliams2014 commented 6 years ago

@Robert-Frampton please keep me in the loop if we decide to lose this functionality. I thought they were useful and a big selling point of the new themes workflow created for 7.0. I didn't realize hardly anyone was using them.

@LucyI https://dev.liferay.com/develop/tutorials/-/knowledge_base/7-0/themelets

jbalsas commented 6 years ago

I think we haven't showcased them properly and demonstrated its usefulness. That might be one of the reasons. I think we can still give them some time to sink and dedicate some efforts to promote them for a little longer.

In any case, I'll be reaching out to Product to see if we can get some more external visibility on this.

jbalsas commented 6 years ago

I'm closing for now, on the assumption that we will keep themelets around. I'll reopen or create a new one if we move on a different direction once we get more data.