search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Create a diversion mechanism to load different modules based on theme version #67

Closed izaera closed 6 years ago

izaera commented 6 years ago

/cc @jbalsas

izaera commented 6 years ago

Hey @Robert-Frampton , this PR is failing in node6 in travis, but correctly working in local. Also, a previous PR worked in node6 so I think the race conditions are happening in Travis too.

Any hint?

robframpton commented 6 years ago

Hey @izaera not sure exactly, but just to rule it out, I sent https://github.com/liferay/liferay-theme-tasks/pull/68 that updates the version of the test runner to see if that resolves anything. I also updated to the latest release of Node 6.x.

robframpton commented 6 years ago

Looks like it worked! I'll go ahead and close this PR in favor of #68