search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Transform file paths sent to the livereload plugin so that it doesn't match incorrect links #77

Closed izaera closed 6 years ago

izaera commented 6 years ago

@Robert-Frampton @jbalsas I have done the change requested by Robert. Please review again and merge if it is OK.

robframpton commented 6 years ago

LGTM.

jbalsas commented 6 years ago

Hey @Robert-Frampton, can you give us a quick crash-course on the current state of this project? Is it fine to just merge to master and run npm publish or is there something else involved?

robframpton commented 6 years ago

Yes, currently you would just merge to master, bump the version: npm version {patch|minor|major}, publish: npm publish, push tags: git push upstream --tags.

There is also a CHANGELOG which was being manually updated on release, but it looks like it hasn't been updated in a while. Maybe we can switch to the tool we are using on metal projects?

jbalsas commented 6 years ago

Cool, we can take care of this tomorrow!