search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

Replaced gulp-util dependencies #80

Closed quodos closed 6 years ago

quodos commented 6 years ago

Replaced all the gulp-util dependencies according to this guide: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

quodos commented 6 years ago

Hm... looks like a lot of the tests fail because gulp-util is being used in the tests. Would need some help with removing that from there.

jbalsas commented 6 years ago

Hey @quodos, thanks for your contribution and for putting this on our radar!

We'll take a look at this soon and figure out what else may be missing to remove the gulp-util dependency.

jbalsas commented 6 years ago

Hey @quodos, we moved this repo to https://github.com/liferay/liferay-themes-sdk

At the time you sent this, we were already embarked in a deep refactor to support more versions and the layout change to a lerna repo. I was unable to bring in your commits without a major headache, so I had to re-do them :(

You can see the PR well we applied it in https://github.com/liferay/liferay-themes-sdk/pull/9, where I tried to thank you in the message commit.

Thanks for bringing this to our attention!