search

liferay / liferay-theme-tasks

A set of tasks for building and deploying Liferay Portal themes.
18 stars 24 forks source link

setup watching of UI files outside of the standard Liferay theme dire… #84

Closed croucha closed 6 years ago

croucha commented 6 years ago

…ctory stucture

croucha commented 6 years ago

Currently, this watcher doesn't monitor single UI files changes to css, js and images outside of the standard Liferay theme directory structure without doing a full build and not a single file update. I have modified it so it will do a single file update for UI files that are not located under the standard src/js, src/images, src/css directories.

croucha commented 6 years ago

I noticed some checks failed here? Is there something I need to do to help with this?

jbalsas commented 6 years ago

Hey @croucha, thanks for the contribution! We will move this PR to https://github.com/liferay/liferay-themes-sdk, which is where we're trying to consolidate all theme tooling, but for now I'd like to continue the conversation here.

Can you explain what's your use case with some more detail? We'd like to fully understand it so we can figure out the best general solution for it.

Thanks!

croucha commented 6 years ago

Hi @jbalsas! Basically I was hoping to have some way for ['deploy:file'] to execute if it detected a JS/CSS/image change outside of src/js/, src/css, src/images. I have a use case were I was storing these assets in a folder like src/portletAssets/portlet1/js/, src/portletAssets/portlet1/css/, src/portletAssets/portlet1/images and it doesn't seem to run ['deploy:file'] when making a change.

Thanks!

jbalsas commented 6 years ago

Hey @croucha, sorry for the delay, I've opened https://github.com/liferay/liferay-themes-sdk/issues/28 and we'll be taking a look at this next!