Open martinaPulieri opened 3 months ago
Well, this situation may in theory occur and was discussed when we implemented support for schemes. In fact, Schemes are browsed by hierarchies. So you start with a top level concept that IS in the scheme and you can start browsing the narrower concepts. Then, if a narrower concept is not in the scheme AND is a leaf then we shall not display it. But if the narrower concept is not in the scheme BUT has itself other narrower concepts then we took the decision to display it in order to get access to the narrower concepts of the narrower concept that could themselves be in the scheme.
Could you confirm this is what's happening here? What would be an alternative behavior according to you?
The behaviour that you are describing is 100% correct, but I know that in this thesaurus, inside this "body shape" concept there isn't any other skos:concept associated to the "PhytoplanktonTraits" scheme. I double checked it also in VocBench to be sure.
Do you mean: Nor this "body shape" concept nor any of its descendants are in the "PhytoplanktonTraits" scheme? If yes, then indeed, it should not display then.
Yes, exactly
Fixed in https://github.com/ontoportal-lirmm/ontologies_linked_data/pull/166, @martinaPulieri you can check it again in https://ecoportal.lifewatchdev.eu/ontologies/TRAITSTEST?p=classes&concept_schemes=https%3A%2F%2Fkos.lifewatch.eu%2Fthesauri%2Ffunctraits%2FconceptScheme_45c75a99&conceptid=https%3A%2F%2Fkos.lifewatch.eu%2Fthesauri%2Ffunctraits%2Fc_621df9ab
It's a start, but I am not sure about this solution. In VocBench, when we select a schema, all the skos:concept that do not belong to that schema are not shown. This way is more user friendly.
It's a start, but I am not sure about this solution. In VocBench, when we select a schema, all the skos:concept that do not belong to that schema are not shown. This way is more user-friendly.
@martinaPulieri it is the case, we don't show the concepts that are not in the scheme, except if the concept has children, as we don't know in advance if they have or not children from the scheme. You can see here the before and after https://github.com/ontoportal-lirmm/ontologies_api/pull/104
It is best if the concepts that do not belong to the concept scheme selected are not shown.
Hi Martina, I got your point too. However, we have to find a response to the situation where a skos:ConceptScheme is not a connected graph (https://en.wikipedia.org/wiki/Connectivity_(graph_theory)#Connected_vertices_and_graphs). I mean the SKOS specification does not status on this: This is ok in SKOS to have a Concept Scheme graph in multiple disconnected part. In that case, the only way for us is to traverse thru concepts that are not in the scheme to connect again with new concepts that could be in the scheme later (when opening the hiearchy down).
To be honnest, I don't think VocBench "manage" this situation... but as an editor it would mean that it does not support or facilitate the fact of creating such disconnected schemes. Still on our side, we could get SKOS resources that will have this.
I am CC @saubin who is also familiar with SKOS for her opinion.
Rediscussed in technical meeting today afternoon. Lets wait for @martinaPulieri and @saubin feedback on this. Technically is easy/possible to do (do not display them) but it "hiding the problem" until someone deposit a SKOS vocabulary that will have the "disconnected graph" situation.
The concepts are not filtered in the proper way by the "Schemes" filter. "Body shape" doesn't belong to the "PhytoplanktonTraits" scheme.