liflab / cornipickle

Versatile web application testing tool
4 stars 3 forks source link

The width of an element does not include its border #2

Open Faterou opened 9 years ago

Faterou commented 9 years ago

Originally reported by: Gabrielle Bastien (Bitbucket: gabrielle_bastien, GitHub: Unknown)


If an element is set to a certain width and has a border, the width read by Cornipickle is less than the given width, because of the border. It could be better to set the default width as the total width (width + border), which represents the total space taken by the element on the page.

Suggestion:


Faterou commented 8 years ago

Original comment by Francis Guérin (Bitbucket: Faterou, GitHub: Faterou):


I agree with that.

Faterou commented 8 years ago

Original comment by Sylvain Hallé (Bitbucket: sylvainhalle, GitHub: sylvainhalle):


Why not just have two different properties with two names:

Faterou commented 8 years ago

Original comment by Francis Guérin (Bitbucket: Faterou, GitHub: Faterou):


Can an object's border influence the properties of other elements on the page? If it's just cosmetic, I'm not sure if always doing width + border is a good idea.

Faterou commented 9 years ago

Original comment by Sylvain Hallé (Bitbucket: sylvainhalle, GitHub: sylvainhalle):


Removing component: JavaScript Probe (automated comment)