ActiveSupport 3.2 - Githubissues

lifo / cramp

Real-time web application framework in Ruby

http://cramp.in

MIT License

1.5k stars 121 forks source link

ActiveSupport 3.2 #47

Closed nicolaracco closed 12 years ago

nicolaracco commented 12 years ago

gems:

inserted group :development with rake and minitest gems
removed thor from gemspec (it seems to be not used)
updated gems (activesupport 3.2)

It seems that tests are all passing now. The major modification was to replace class_inheritable_accessor with class_attribute

nicolaracco commented 12 years ago

Sorry, I didn't noticed thor was used for generators. I'll open another pull request without touching thor :)

wtn commented 12 years ago

Your request is nearly identical to mine: https://github.com/wtn/cramp/commit/9b58f81125a040abb19ce08821d5a32514deb31c

nicolaracco commented 12 years ago

There is also this change: https://github.com/lifo/cramp/pull/47/files#L5R13

Vasfed commented 12 years ago

same changes are also in https://github.com/lifo/cramp/pull/45 ...

wtn commented 12 years ago

Is there a reason to block people from using these mods with activerecord/activesupport 3.1?

That's when the new methods were added and the old ones were deprecated… Not sure why your patches are restrictive.

Vasfed commented 12 years ago

class_attribute was introduced in 3.0 as i remember, but actually we can do some respond_to-magic and loosen dependencies to somewhere near >=2.1

nicolaracco commented 12 years ago

Yes, you are right indeed. Sorry for my noobbish pull requests of yesterday. I updated the other pull request I created yesterday (https://github.com/lifo/cramp/pull/48) with another commit that reenable activesupport 3.0.9 in gemspec.

wtn commented 12 years ago

Nice :)

I'll delete mine