search

lifrordi / DeepStack-Leduc

Example implementation of the DeepStack algorithm for no-limit Leduc poker
https://www.deepstack.ai/
878 stars 211 forks source link

Terminal equity weight incorrect #18

Closed bobbiesbob closed 6 years ago

bobbiesbob commented 6 years ago

In line 91 of terminal_equity.lua in the board_card_count == 1 case, it should be

1/(game_settings.card_count - 1)

rather than

1/(game_settings.card_count - 2)

since there are 5 valid boards for each hand, the denominator should be 5.

I tested with Tree/test_tree_cfr.lua and the modification produces a lower exploitability.

tijiang13 commented 6 years ago

Put aside your conclusion, I think your argument cannot support your point of view — by editing the payoff, you created a different game. If you change:

1/(game_settings.card_count - 1)

into

1/(game_settings.card_count)

You’ll get a even lower “exploitability” : )