bug with the node_type variable in _get_children_player_node(...) - Githubissues

lifrordi / DeepStack-Leduc

Example implementation of the DeepStack algorithm for no-limit Leduc poker

https://www.deepstack.ai/

878 stars 211 forks source link

bug with the node_type variable in _get_children_player_node(...) #2

Closed snarb closed 6 years ago

snarb commented 7 years ago

Looks like you accidentally store node type in the check_node.type variable in one place: https://github.com/lifrordi/DeepStack-Leduc/blob/bd344cafb7b96800619dfde4430a2c9610da76a9/Source/Tree/tree_builder.lua#L123 and in the chance_node.node_type in other https://github.com/lifrordi/DeepStack-Leduc/blob/bd344cafb7b96800619dfde4430a2c9610da76a9/Source/Tree/tree_builder.lua#L134. Is this a bug? I can make a PR if you confirm.