lifrordi / DeepStack-Leduc

Example implementation of the DeepStack algorithm for no-limit Leduc poker
https://www.deepstack.ai/
891 stars 211 forks source link

Malfunctioning `test_tree_visualiser.lua` #6

Closed mathemage closed 6 years ago

mathemage commented 6 years ago

Hi @lifrordi !

When my settings Settings/arguments.lua is:

--- list of pot-scaled bet sizes to use in tree
-- @field params.bet_sizing
params.bet_sizing = {1}

and visualizing by running command:

$ th Tree/Tests/test_tree_visualiser.lua

I get the following visualization: simple_tree_1bet

However, when I modify Settings/arguments.lua as follows:

params.bet_sizing = {1, 2}

and when I run the very same command, I get this visualization: simple_tree_12bet This is obviously incorrect, since we should have more bet actions, namely "2-pot bet". Am I missing something, or are the two visualizations supposed to be identical?

Thanks for clarification!

mathemage commented 6 years ago

But when I run test_tree_values.lua, it seems to makes difference!

For 1-pot bets:

$ th Tree/Tests/test_tree_values.lua 
Exploitability: 175.52084350586[chips]  

For 1- and 2-pot bets:

$ th Tree/Tests/test_tree_values.lua 
Exploitability: 197.78327178955[chips]  
snarb commented 6 years ago

You can't get 2x in that situation. Stack size is 300 + 300 = 600. 1x bet is +600. That is ok. But 2x bet will be +1200, totally 600 + 1200 = 1800 that is impossible with stack size 1200.

mathemage commented 6 years ago

@snarb Oh I see, the stack sizes are set to 1200. I haven't noticed that... I was simply following the tutorial, where it is not mentioned.

@lifrordi I suggest mentioning it there.

mathemage commented 6 years ago

Increasing stack sizes to 12000 works: simple_tree_12bet_stack12000

Thanks a lot, @snarb & @lifrordi !