search

lifs-tools / rgoslin

Rgoslin Repository for Bioconductor submission
MIT License
5 stars 0 forks source link

LHexCer 18:1;O2 is not parseable #25

Closed burlab closed 1 year ago

burlab commented 1 year ago

Hi,

when I run the lines below, then 1 and 2 are fine, but 3 returns NOT_PARSEABLE, even for 1 and 2 LHexCer 18:1;O2 is returned in Normalized.Name. Is this an expected behaviour? Thank you for your time!

1) parseLipidNames("LHexCer d18:1") 2) parseLipidNames("LHexCer 18:1;2") 3) parseLipidNames("LHexCer 18:1;O2")

dominik-kopczynski commented 1 year ago

Hi Bo, Thank you for the report. On my way to search the problem.

dominik-kopczynski commented 1 year ago

Yuup, I found the error, we simply forgot to write LHexCer into the shorthand grammar. I fixed it and created a pull request for merging it into the main branch. Meanwhile, you can test the fixed version in the 'dev_issue_25' branch. Cheers, Dominik PS: if there still are some problems regarding this issue, do not hesitate to reopen the bug report again.

burlab commented 1 year ago

Hi Dominik, thanks a lot, it works now!