lift / framework

Lift Framework
http://liftweb.net
Apache License 2.0
1.27k stars 278 forks source link

StackOverFlow error caused by recursion in newConnection #1341

Open dj22 opened 12 years ago

dj22 commented 12 years ago

In DB.scala newConnection can fail and recursively call itself until the stack overflows. We have seen this happen using both Oracle and H2-Server when the database becomes unavailable and therefore connections to it fail.

serioga commented 11 years ago

The link to discussion is https://groups.google.com/d/topic/liftweb/hHW_R9Rd4uY/discussion

constantine2nd commented 1 year ago

Solution: Fix bug and prevent StackOverFlow via loop function

Fix: do not increase the pool size in case of invalid connection Improvement: rewrite recursive to loop function