search

lift / framework

Lift Framework
http://liftweb.net
Apache License 2.0
1.27k stars 280 forks source link

Adding support for SameSite cookies #1990

Closed csaltos closed 3 years ago

csaltos commented 3 years ago

Mailing List thread:

SameSite is a required field for nowadays web security and since Servlet API does not support it yet, this PR tries to give it support at Scala level for Lift via Netty.

We are going to use this patch for Lift at Talenteca.com and I hope you find this PR valuable for other people too.

Best regards,

Carlos Saltos

csaltos commented 3 years ago

Yes, of course, Matt, good point !! ... I will gladly try to do it next week.

csaltos commented 3 years ago

Ready dear Matt, now it works with an internal cookie encoder and I also added some tests that are important.

Please let me know if it's OK now ... and if it needs further improvements, please let me know, I will do them gladly.

Best regards,

Carlos Saltos

csaltos commented 3 years ago

Thank YOU, dear Matt !! :+1::sunglasses:

csaltos commented 3 years ago

Thanks for the merge !! :+1::sunglasses: