search

liftbridge-io / go-liftbridge

Go client for Liftbridge. https://github.com/liftbridge-io/liftbridge
Apache License 2.0
67 stars 18 forks source link

Improvement: allow overriding a host for standalone-dev image. #68

Closed ruseinov closed 3 years ago

ruseinov commented 3 years ago

Hello @tylertreat!

I'm trying to test the Rust client I'm currently working on, but the issue is that I don't run my docker host on localhost (docker-machine). And the LIFTBRIDGE_HOST env variable does not seem to have any effect as there is no default config available in standalone-dev image.

It would be nice to be able to override the host without any extra actions.

ruseinov commented 3 years ago

I'm happy to contribute, just not sure where this image is coming from :/

ruseinov commented 3 years ago

Was not sure where to put this issue, so closing it in hopes that we can discuss this here.

tylertreat commented 3 years ago

@ruseinov Can you open an issue on the https://github.com/liftbridge-io/liftbridge repo? The dev-standalone image is built here: https://github.com/liftbridge-io/liftbridge/tree/master/docker/dev-standalone

ruseinov commented 3 years ago

Done!

On Mon, 17 Aug 2020 at 17:16, Tyler Treat notifications@github.com wrote:

@ruseinov https://github.com/ruseinov Can you open an issue on the https://github.com/liftbridge-io/liftbridge repo? The dev-standalone image is built here: https://github.com/liftbridge-io/liftbridge/tree/master/docker/dev-standalone

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/liftbridge-io/go-liftbridge/issues/68#issuecomment-674942721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACP7ENDM2NMVJ3ZCCKZ3R3SBFCWTANCNFSM4P7MFKRQ .