search

liftbridge-io / liftbridge-rs

Liftbridge client for Rust language.
Apache License 2.0
1 stars 1 forks source link

Introduce a wrapper on top of the api client generated from protobuf #1

Closed ruseinov closed 4 years ago

ruseinov commented 4 years ago

This PR aims at providing a minimal wrapper on top of the client generated from protobuf definitions.

ruseinov commented 4 years ago

@tylertreat FYI

ruseinov commented 4 years ago

@tylertreat thanks for the review, I have introduced some TODOs and will to address them very soon. Then we can merge this and move to liftbridge org if that works for you.

tylertreat commented 4 years ago

Yep, lgtm. I believe you need to initiate a transfer to @liftbridge-io after merging.

ruseinov commented 4 years ago

@tylertreat Yeah, but I need to be added to the org and have permissions ti create a public repo though!

tylertreat commented 4 years ago

@ruseinov Invitation sent

ruseinov commented 4 years ago

@tylertreat great! if you could also make me an admin for that one repo - that would be awesome.

I’ll probably be working on ci setup soon as well as changing the settings on how branches and prs get merged.

tylertreat commented 4 years ago

Done!