search

liftedinit / alberto

A crypto wallet for any ledger supporting the Many protocol
https://alberto.app
Apache License 2.0
6 stars 7 forks source link

fix: allow the modal process to finish even when home changes #112

Closed hansl closed 1 year ago

hansl commented 1 year ago

The bug happened because the account was selected, causing the Home page to transfer to listing the account assets, causing the Modal component to be garbage collected. Instead of waiting for the modal to be completed before choosing the account (which would have moved a lot of logic outside the modal), moving the modal ownership to the top-level app was the least amount of change to fix the bug.

This code needs a good overhaul at some point. But this wont be the time nor the place.

Fixes https://github.com/liftedinit/alberto/issues/111

netlify[bot] commented 1 year ago

Deploy Preview for lifted-alberto ready!

Name Link
Latest commit 15930d5abcc22b891c8e6c254bf6d6fccf678e0a
Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/6408e619b66c0f0008e711fc
Deploy Preview https://deploy-preview-112--lifted-alberto.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stanleyjones commented 1 year ago

Is this ready for review? I see some console logging still in there.