build: Remove ManyJS from UI library (Alberto)

stanleyjones commented 1 year ago

See https://github.com/liftedinit/lifted-ui/pull/12 for more context.

Basically three things here:

Moved JSON helper (resolver, reviver) from LiftedUI and changed imports to point to it.
Moved AddressText component from LiftedUI and changed imports to point to it.
Uh... 🤔

netlify[bot] commented 1 year ago

Deploy Preview for lifted-alberto ready!

Name	Link
Latest commit	aed2c436d68b72cdffe52dca62939b973e245f71
Latest deploy log	https://app.netlify.com/sites/lifted-alberto/deploys/640a54ef09d1cc0008ea439a
Deploy Preview	https://deploy-preview-114--lifted-alberto.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stanleyjones commented 1 year ago

Tests are failing. Going to investigate and come back to this. Marking as draft for now.

stanleyjones commented 1 year ago

Posting results from the end-to-end tests to prove that we have them (cc @fmorency ):

❯ npm run test:e2e

> alberto@0.1.0-alpha.9 test:e2e
> npx playwright test --config=./e2e/playwright.config.ts

Running 55 tests using 10 workers

  ✓  [webkit] › tests/home.spec.ts:19:1 › send tokens (18s)
  ✓  [webkit] › tests/accounts.spec.ts:52:1 › submit, approve, revoke, and execute a multisig transaction (1m)
  ✓  [firefox] › tests/home.spec.ts:19:1 › send tokens (16s)
  ✓  [pixel-5] › tests/home.spec.ts:19:1 › send tokens (29s)
  ✓  [iphone12-promax] › tests/home.spec.ts:19:1 › send tokens (16s)
  ✓  [chromium] › tests/home.spec.ts:19:1 › send tokens (16s)
  ✓  [firefox] › tests/accounts.spec.ts:52:1 › submit, approve, revoke, and execute a multisig transaction (1m)
  ✓  [pixel-5] › tests/accounts.spec.ts:52:1 › submit, approve, revoke, and execute a multisig transaction (1m)
  ✓  [chromium] › tests/accounts.spec.ts:52:1 › submit, approve, revoke, and execute a multisig transaction (1m)
  ✓  [iphone12-promax] › tests/accounts.spec.ts:52:1 › submit, approve, revoke, and execute a multisig transaction (1m)
  ✓  [chromium] › tests/home.spec.ts:42:1 › edit wallet name (8s)
  ✓  [iphone12-promax] › tests/home.spec.ts:42:1 › edit wallet name (13s)
  ✓  [firefox] › tests/home.spec.ts:42:1 › edit wallet name (8s)
  ✓  [webkit] › tests/home.spec.ts:42:1 › edit wallet name (9s)
  ✓  [chromium] › tests/home.spec.ts:54:1 › remove wallet (7s)
  ✓  [firefox] › tests/home.spec.ts:54:1 › remove wallet (7s)
  ✓  [webkit] › tests/home.spec.ts:54:1 › remove wallet (8s)
  ✓  [iphone12-promax] › tests/home.spec.ts:54:1 › remove wallet (13s)
  ✓  [pixel-5] › tests/home.spec.ts:42:1 › edit wallet name (17s)
  ✓  [chromium] › tests/home.spec.ts:71:1 › add a network (8s)
  ✓  [firefox] › tests/home.spec.ts:71:1 › add a network (8s)
  ✓  [webkit] › tests/home.spec.ts:71:1 › add a network (8s)
  ✓  [chromium] › tests/home.spec.ts:82:1 › edit a network (7s)
  ✓  [firefox] › tests/home.spec.ts:82:1 › edit a network (8s)
  ✓  [iphone12-promax] › tests/home.spec.ts:71:1 › add a network (16s)
  ✓  [webkit] › tests/home.spec.ts:82:1 › edit a network (8s)
  ✓  [chromium] › tests/home.spec.ts:92:1 › remove a network (7s)
  ✓  [pixel-5] › tests/home.spec.ts:54:1 › remove wallet (16s)
  ✓  [firefox] › tests/home.spec.ts:92:1 › remove a network (7s)
  ✓  [webkit] › tests/home.spec.ts:92:1 › remove a network (8s)
  ✓  [iphone12-promax] › tests/home.spec.ts:82:1 › edit a network (16s)
  ✓  [pixel-5] › tests/home.spec.ts:71:1 › add a network (16s)
  ✓  [webkit] › tests/accounts.spec.ts:98:1 › cannot modify multisig settings per transaction (33s)
  ✓  [firefox] › tests/accounts.spec.ts:98:1 › cannot modify multisig settings per transaction (28s)
  ✓  [iphone12-promax] › tests/home.spec.ts:92:1 › remove a network (16s)
  ✓  [iphone12-promax] › tests/accounts.spec.ts:98:1 › cannot modify multisig settings per transaction (33s)
  ✓  [pixel-5] › tests/accounts.spec.ts:98:1 › cannot modify multisig settings per transaction (40s)
  ✓  [pixel-5] › tests/home.spec.ts:82:1 › edit a network (15s)
  ✓  [chromium] › tests/accounts.spec.ts:98:1 › cannot modify multisig settings per transaction (33s)
  ✓  [pixel-5] › tests/home.spec.ts:92:1 › remove a network (15s)
  ✓  [firefox] › tests/accounts.spec.ts:135:1 › disallow submitting multisig transaction (39s)
  ✓  [webkit] › tests/accounts.spec.ts:135:1 › disallow submitting multisig transaction (36s)
  ✓  [iphone12-promax] › tests/accounts.spec.ts:135:1 › disallow submitting multisig transaction (49s)
  ✓  [chromium] › tests/accounts.spec.ts:135:1 › disallow submitting multisig transaction (35s)
  ✓  [pixel-5] › tests/accounts.spec.ts:135:1 › disallow submitting multisig transaction (40s)
  ✓  [firefox] › tests/accounts.spec.ts:156:1 › modify multisig settings (40s)
  ✓  [webkit] › tests/accounts.spec.ts:156:1 › modify multisig settings (39s)
  ✓  [chromium] › tests/accounts.spec.ts:156:1 › modify multisig settings (44s)
  ✓  [pixel-5] › tests/accounts.spec.ts:156:1 › modify multisig settings (43s)
  ✓  [iphone12-promax] › tests/accounts.spec.ts:156:1 › modify multisig settings (52s)
  ✓  [webkit] › tests/accounts.spec.ts:178:1 › add and remove owner (54s)
  ✓  [firefox] › tests/accounts.spec.ts:178:1 › add and remove owner (49s)
  ✓  [chromium] › tests/accounts.spec.ts:178:1 › add and remove owner (49s)
  ✓  [pixel-5] › tests/accounts.spec.ts:178:1 › add and remove owner (1m)
  ✓  [iphone12-promax] › tests/accounts.spec.ts:178:1 › add and remove owner (59s)

  Slow test file: [iphone12-promax] › tests/accounts.spec.ts (4m)
  Slow test file: [pixel-5] › tests/accounts.spec.ts (4m)
  Slow test file: [chromium] › tests/accounts.spec.ts (4m)
  Slow test file: [webkit] › tests/accounts.spec.ts (4m)
  Slow test file: [firefox] › tests/accounts.spec.ts (4m)
  Consider splitting slow test files to speed up parallel execution

  55 passed (5m)

fmorency commented 1 year ago

Looking good @stanleyjones. Some questions:

Are those running in the CI? I see some tests but not those, e.g., https://app.circleci.com/pipelines/github/liftedinit/alberto/204/workflows/f1d1217c-0937-438f-92f7-6a4eb2b792b2/jobs/443
Could we integrate code coverage? We're already using CodeCov in https://github.com/liftedinit/many-rs/
Would be nice to have some badges in the README reporting build and coverage status for main

stanleyjones commented 1 year ago

@fmorency All good suggestions. I'll add them to my list.

The end-to-end tests require many-rs so we run them locally as a pre-push hook. It would take a little work to get them into CI but I think it would be worth it.

stanleyjones commented 1 year ago

I'm actually going to close this PR and take a different approach at removing ManyJS from the UI library.

liftedinit / alberto