liftedinit / alberto

A crypto wallet for any ledger supporting the Many protocol
https://alberto.app
Apache License 2.0
6 stars 7 forks source link

fix: multisig tx details #124

Closed fmorency closed 1 year ago

fmorency commented 1 year ago

Retrieve multisig transaction details from current and legacy networks.

This PR support N legacy networks.

Any multisig transaction in a pending state on a legacy network will need to be re-created on the new network. Those pending multisig will remain pending indefinitely, as we do not want to modify the legacy storage.

Future work:

I also did some small refactoring.

@stanleyjones is there a reason why we're not using more native many-js types in Alberto, e.g., we're using string instead of MultisigTransactionState. I saw this behavior often in Gwen/Alberto and was wondering what the reason was.

netlify[bot] commented 1 year ago

Deploy Preview for lifted-alberto ready!

Name Link
Latest commit c53f81c557decdc948e9b5564cb7adb9dd01dd7a
Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/64c13a95a6fac5000804c0a6
Deploy Preview https://deploy-preview-124--lifted-alberto.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.