search

liftedinit / alberto

A crypto wallet for any ledger supporting the Many protocol
https://alberto.app
Apache License 2.0
6 stars 7 forks source link

feat: Disable Hardware Authenticator identities for unsupported Networks #140

Closed stanleyjones closed 11 months ago

stanleyjones commented 1 year ago

See liftedinit/gwen#75

Closes #135

netlify[bot] commented 1 year ago

Deploy Preview for lifted-alberto ready!

Name Link
Latest commit cd3d1e35b01c8efe8bdbb79d0b79a417f53f80bd
Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/65280a7e1967350008037e3e
Deploy Preview https://deploy-preview-140--lifted-alberto.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 year ago

Codecov Report

Merging #140 (cd3d1e3) into main (de373d2) will increase coverage by 0.52%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   33.82%   34.35%   +0.52%     
==========================================
  Files          89       89              
  Lines        2282     2308      +26     
  Branches      655      659       +4     
==========================================
+ Hits          772      793      +21     
- Misses       1499     1504       +5     
  Partials       11       11
Files Coverage Ξ”
...nts/components/accounts-menu/add-account-modal.tsx 98.21% <90.90%> (+0.13%) :arrow_up:
...ccounts/components/accounts-menu/accounts-menu.tsx 88.00% <77.77%> (-2.48%) :arrow_down:
src/features/network/network-provider.tsx 91.42% <81.25%> (-8.58%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

stanleyjones commented 11 months ago

Looking into CI failures. I think it's a package that was updated in main but not this branch.

stanleyjones commented 11 months ago

Okay, should look pretty similar to liftedinit/gwen#75. Reviews welcome.

fmorency commented 11 months ago

I can't create a new HSM account on QA. @jgryffindor is this an infra or an Alberto issue?

2023-10-11_10-08

jgryffindor commented 11 months ago

I'm getting the same result. The release is out in QA so if there aren't any new infra requirements for this feature then it's something in the release.

fmorency commented 11 months ago

@stanleyjones I don't think the issue I reported above is related to this PR. I will investigate.

Could you start working on #142 ?

fmorency commented 11 months ago

Fixed in https://github.com/liftedinit/alberto/pull/147

fmorency commented 11 months ago

Tested in QA, everything LGTM. Thanks @stanleyjones