liftedinit / alberto

A crypto wallet for any ledger supporting the Many protocol
https://alberto.app
Apache License 2.0
6 stars 7 forks source link

feat: refactor network provider #144

Closed fmorency closed 1 year ago

fmorency commented 1 year ago

Reconcile code from https://github.com/liftedinit/gwen/pull/75 and automate some boilerplate.

netlify[bot] commented 1 year ago

Deploy Preview for lifted-alberto ready!

Name Link
Latest commit 0466a7b919a1eb9a2c48de81d16c68608193c740
Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/6515be94f775c50007c6b8b2
Deploy Preview https://deploy-preview-144--lifted-alberto.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fmorency commented 1 year ago

I can't run the pre-commit tests because of a glibc compatibility issue. Can someone run those, please?

fmorency commented 1 year ago

Checking CI issue...

codecov[bot] commented 1 year ago

Codecov Report

Merging #144 (0466a7b) into main (3b8894a) will increase coverage by 0.35%. The diff coverage is 74.50%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   34.08%   34.43%   +0.35%     
==========================================
  Files          88       88              
  Lines        2265     2262       -3     
  Branches      659      654       -5     
==========================================
+ Hits          772      779       +7     
+ Misses       1482     1472      -10     
  Partials       11       11              
Files Coverage Δ
src/features/accounts/api/get-account-info.ts 41.66% <100.00%> (ø)
src/features/balances/queries.ts 96.15% <100.00%> (ø)
...s/network/components/network-menu/network-menu.tsx 90.90% <100.00%> (+0.49%) :arrow_up:
src/features/network/network-provider.tsx 100.00% <100.00%> (ø)
src/views/home/home.tsx 100.00% <100.00%> (ø)
src/features/accounts/api/add-roles.ts 0.00% <0.00%> (ø)
src/features/accounts/api/get-multisig-txn-info.ts 3.12% <0.00%> (ø)
src/features/accounts/api/multisig-approve.ts 0.00% <0.00%> (ø)
src/features/accounts/api/multisig-execute.ts 0.00% <0.00%> (ø)
src/features/accounts/api/multisig-revoke.ts 0.00% <0.00%> (ø)
... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fmorency commented 1 year ago

Okay, I fixed the tests.

Alberto needs some love.