feat: Running balance in Transaction List

stanleyjones commented 9 months ago

SCREENSHOT

[x] Send events
[x] Mint events
[x] Burn events

Closes #142

netlify[bot] commented 9 months ago

Deploy Preview for lifted-alberto ready!

Name	Link
Latest commit	fee7affc93e77868745e21337d6134acf2c3a0b3
Latest deploy log	https://app.netlify.com/sites/lifted-alberto/deploys/6572142072eeee0008b94ac4
Deploy Preview	https://deploy-preview-149--lifted-alberto.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stanleyjones commented 9 months ago

Requesting a review just to make sure I'm on the right track. This PR is not ready to merge.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5c00a1f) 35.10% compared to head (fee7aff) 35.48%.

Files	Patch %	Lines
src/features/transactions/queries.ts	66.66%	8 Missing :warning:
...txn-list/txn-list-item/mint-burn-txn-list-item.tsx	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== + Coverage 35.10% 35.48% +0.38% ========================================== Files 90 90 Lines 2396 2429 +33 Branches 683 695 +12 ========================================== + Hits 841 862 +21 - Misses 1544 1555 +11 - Partials 11 12 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmorency commented 9 months ago

Requesting a review just to make sure I'm on the right track. This PR is not ready to merge.

It's fine! It looks robust to the treasury edge case where the initial account value is not 0?

liftedinit / alberto