liftedinit / alberto

A crypto wallet for any ledger supporting the Many protocol
https://alberto.app
Apache License 2.0
6 stars 7 forks source link

beginning and end characters of address text should be visible #81

Closed tt0mmy closed 2 years ago

tt0mmy commented 2 years ago

Description

Related Issue

Fixes https://github.com/liftedinit/albert/issues/80 Fixes https://github.com/liftedinit/albert/issues/60

Testing

Screenshots (if applicable)

Before: image

After: image

tt0mmy commented 2 years ago

merge https://github.com/liftedinit/albert/pull/72 first

fmorency commented 2 years ago

Thanks for this @tantommy.

Not sure if relevant but here are some screenshots of dialogs that don't appear fixed.

2022-09-13_16-21

2022-09-13_16-23

2022-09-13_16-24

I didn't test the transaction history

hansl commented 2 years ago

@fmorency can you specify which OS and Browser (including exact versions) you're using?

fmorency commented 2 years ago

@fmorency can you specify which OS and Browser (including exact versions) you're using?

Linux Manjaro 22.0.0, Kernel 5.10.136 Firefox 104.0.2

tt0mmy commented 2 years ago

Thanks for this @tantommy.

Not sure if relevant but here are some screenshots of dialogs that don't appear fixed.

  • the "Send" dialog

2022-09-13_16-21

  • the "add account" dialog

2022-09-13_16-23

  • after account creation

2022-09-13_16-24

I didn't test the transaction history

these should be acceptable as they are actual Input elements and can be clicked on to view the full address.

this PR fixes any of the address that are display only. For example, when creating a transaction (sending tokens) and the confirmation screen appears. The address here is cutoff and cannot be clicked on to view the full address. In these cases, we will shorten the address so that the beginning and end characters are shown.