feat: add pagination to deployments [6]

nblenke commented 9 months ago

Description

Adding pagination to deployments page
bump @liftedinit/gcjs to 0.0.6

Related Issue

Fixes #6

Testing

Breaking Changes (if applicable)

Screenshots (if applicable)

https://github.com/liftedinit/ghostcloud-cosmos-frontend/assets/649166/1d074c21-caf9-4aa7-ad26-4043f3b15759

Checklist:

[x] I have read and followed the CONTRIBUTING guidelines for this project.
x] I have added or updated tests and they pass.
[x] I have added or updated documentation and it is accurate.
[x] I have noted any breaking changes in this module or downstream modules.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5e121df) 57.51% compared to head (4da4b3a) 52.56%.

Files	Patch %	Lines
lib/ghostcloud.ts	16.66%	15 Missing :warning:
components/dashboard.tsx	28.57%	10 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 57.51% 52.56% -4.96% ========================================== Files 21 21 Lines 426 449 +23 Branches 52 58 +6 ========================================== - Hits 245 236 -9 - Misses 164 196 +32 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmorency commented 9 months ago

FYI, the pagination goes past page 2 after refreshing the page.

nblenke commented 8 months ago

FYI, the pagination goes past page 2 after refreshing the page.

I noticed this as well after more testing, I think this was a combination of not refetching when adding deployments and my implementation of using pagination key being a bit flaky

liftedinit / ghostcloud-frontend