27 - Githubissues

nblenke commented 7 months ago

Description

Create hook to check if there is a sessionId in localStorage
Create login wrapper to check for sessionId, if present re-call handleLogin, but without redirect. This allows users to remain on another page on hard refresh
Remove error that would appear if metas were not present on deployment component. This would appear briefly during hard refresh. A toast error will be presented if the query fails

Related Issue

Fixes # 27

Testing

Breaking Changes (if applicable)

Screenshots (if applicable)

Checklist:

[ ] I have read and followed the CONTRIBUTING guidelines for this project.
[ ] I have added or updated tests and they pass.
[ ] I have added or updated documentation and it is accurate.
[ ] I have noted any breaking changes in this module or downstream modules.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.37%. Comparing base (7db180b) to head (aa3fe91).

:exclamation: Current head aa3fe91 differs from pull request most recent head a6f3d39. Consider uploading reports for the commit a6f3d39 to get more accurate results

Files	Patch %	Lines
components/dashboard.tsx	35.29%	11 Missing :warning:
hooks/useOpenLoginSession.ts	85.71%	2 Missing :warning:
pages/index.tsx	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== + Coverage 53.47% 55.37% +1.90% ========================================== Files 23 24 +1 Lines 475 502 +27 Branches 63 68 +5 ========================================== + Hits 254 278 +24 - Misses 202 205 +3 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nblenke commented 7 months ago

Hey @nblenke, a few more comments.

The user is still not redirected to the dashboard after logging in.

This is on purpose. My thought was that if they were on the homepage/terms of service and refreshed, they would remain on the same page and not be redirected to the dashboard

Pressing the Get Started button on the main page while being logged in does nothing.

Fixed

fmorency commented 6 months ago

Hey @nblenke, a few more comments.

The user is still not redirected to the dashboard after logging in.

This is on purpose. My thought was that if they were on the homepage/terms of service and refreshed, they would remain on the same page and not be redirected to the dashboard

Is there any way to support both? I don't like that a first-time user is not redirected to the dashboard after logging in.

nblenke commented 6 months ago