search

liftedinit / manifest-ledger

CosmosSDK-based blockchain ledger for the Manifest Network
Apache License 2.0
0 stars 2 forks source link

chore: remove panic usage in keeper methods #49

Closed fmorency closed 2 months ago

fmorency commented 2 months ago

This PR removes the panic usage in keeper methods. This should fix the remaining CodeQL warnings.

Code hygiene following https://github.com/cosmos/cosmos-sdk/pull/18636, https://github.com/cosmos/cosmos-sdk/pull/16212 and https://github.com/cosmos/cosmos-sdk/issues/12985

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 59.69%. Comparing base (6a7913e) to head (e77fe05).

Files Patch % Lines
x/manifest/keeper/keeper.go 50.00% 6 Missing and 2 partials :warning:
x/manifest/abci.go 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================== - Coverage 59.86% 59.69% -0.17% ========================================== Files 34 34 Lines 2145 2151 +6 ========================================== Hits 1284 1284 - Misses 802 805 +3 - Partials 59 62 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.