liftedinit / manifest-ledger

CosmosSDK-based blockchain ledger for the Manifest Network
Apache License 2.0
0 stars 2 forks source link

test: group poa admin #62

Closed fmorency closed 1 month ago

fmorency commented 1 month ago

Add Group Proposal tests for when POA is a group address (group admin is the group policy itself).

Test

This PR is becoming huge so I want to get those merged. We can add more tests later.

Fixes #61

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.05085% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.31%. Comparing base (b16de8e) to head (7791945).

Files Patch % Lines
interchaintest/helpers/group.go 84.31% 4 Missing and 4 partials :warning:
x/manifest/types/params.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== + Coverage 71.96% 72.31% +0.34% ========================================== Files 32 33 +1 Lines 1737 1795 +58 ========================================== + Hits 1250 1298 +48 - Misses 427 432 +5 - Partials 60 65 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmorency commented 1 month ago

I'll re-run CI tomorrow, the test is failing because we reached the maximum number of Docker requests.