liftedinit / manifest-ledger

CosmosSDK-based blockchain ledger for the Manifest Network
Apache License 2.0
0 stars 3 forks source link

Implement `app_v2` wiring #82

Open fmorency opened 1 month ago

fmorency commented 1 month ago

Using app_v1 is causing the TestAppImportExport simulation to fail in CosmosSDK v0.50.6.

I see a similar behavior on https://github.com/liftedinit/manifest-ledger/pull/76.

KV stores are different: 26 key/value pairs in store A and 0 key/value pairs in store B
    sim_test.go:332: 
                Error Trace:    /home/fmorency/dev/manifest-ledger/app/sim_test.go:332
                Error:          Not equal: 
                                expected: 26
                                actual  : 0
                Test:           TestAppImportExport
                Messages:       unequal sets of key-values to compare upgrade

The issue doesn't occur when using app_v2 wiring in CosmosSDK. Implement app_v2 wiring in this application and see if it fixes the problem.

Relates https://github.com/strangelove-ventures/poa/issues/199 Relates https://github.com/strangelove-ventures/tokenfactory/issues/13

Implement v2 wiring in

fmorency commented 1 month ago

manifest-ledger depends on ibc which is incompatible with v2 wiring.

See https://github.com/cosmos/ibc-go/issues/3560