search

lifthrasiir / rust-encoding

Character encoding support for Rust
MIT License
284 stars 59 forks source link

warning: private trait in public interface (error E0445) #102

Closed getreu closed 8 years ago

getreu commented 8 years ago 
Compiling encoding v0.3.0-dev (file:///rust-encoding-master)
src/codec/utf_16.rs:86:9: 86:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/utf_16.rs:86 impl<E: Endian> Encoding for UTF16Encoding<E> {
                               ^~~~~~
src/codec/utf_16.rs:86:9: 86:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/utf_16.rs:86:9: 86:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/utf_16.rs:106:9: 106:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/utf_16.rs:106 impl<E: Endian> UTF16Encoder<E> {
                                ^~~~~~
src/codec/utf_16.rs:106:9: 106:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/utf_16.rs:106:9: 106:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/utf_16.rs:112:9: 112:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/utf_16.rs:112 impl<E: Endian> RawEncoder for UTF16Encoder<E> {
                                ^~~~~~
src/codec/utf_16.rs:112:9: 112:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/utf_16.rs:112:9: 112:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/utf_16.rs:159:9: 159:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/utf_16.rs:159 impl<E: Endian> UTF16Decoder<E> {
                                ^~~~~~
src/codec/utf_16.rs:159:9: 159:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/utf_16.rs:159:9: 159:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/utf_16.rs:166:9: 166:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/utf_16.rs:166 impl<E: Endian> RawDecoder for UTF16Decoder<E> {
                                ^~~~~~
src/codec/utf_16.rs:166:9: 166:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/utf_16.rs:166:9: 166:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/simpchinese.rs:90:9: 90:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/simpchinese.rs:90 impl<T: GBType> Encoding for GBEncoding<T> {
                                    ^~~~~~
src/codec/simpchinese.rs:90:9: 90:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/simpchinese.rs:90:9: 90:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/simpchinese.rs:110:9: 110:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/simpchinese.rs:110 impl<T: GBType> GBEncoder<T> {
                                     ^~~~~~
src/codec/simpchinese.rs:110:9: 110:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/simpchinese.rs:110:9: 110:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/codec/simpchinese.rs:116:9: 116:15 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/codec/simpchinese.rs:116 impl<T: GBType> RawEncoder for GBEncoder<T> {
                                     ^~~~~~
src/codec/simpchinese.rs:116:9: 116:15 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/codec/simpchinese.rs:116:9: 116:15 note: for more information, see the explanation for E0446 (`--explain E0446`)
lifthrasiir commented 8 years ago

A quick fix available in 0.2.33. Sorry for the delay!